[webkit-reviews] review requested: [Bug 128115] [Win] LLINT is not working. : [Attachment 223887] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 128115: [Win] LLINT is not working.
https://bugs.webkit.org/show_bug.cgi?id=128115

Attachment 223887: Patch
https://bugs.webkit.org/attachment.cgi?id=223887&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
I didn't realize that you've made these additional code changes not in the
original review.  I'll need to take a closer look at this again.

Regarding the stack alignment issue, I may be able to make some suggestions if
you can post some debugging info on the issue you're seeing e.g. what is the
value of the frame pointer and stack pointer when the assertion fails.

Also, to help you debug the issue, I recommend disabling the JIT first and
making sure that the assembly LLINT works.  You can do that by setting an
environment var JSC_useJIT=false.   Alternatively, you can temporarily change
useJIT to false in Options.h.