[webkit-reviews] review granted: [Bug 128402] Implement DataCue for metadata cues : [Attachment 223870] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 128402: Implement DataCue for metadata cues
https://bugs.webkit.org/show_bug.cgi?id=128402

Attachment 223870: Patch
https://bugs.webkit.org/attachment.cgi?id=223870&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223870&action=review


> Source/WebCore/html/track/DataCue.cpp:55
> +    return const_cast<DataCue*>(toDataCue(const_cast<const
TextTrackCue*>(cue)));

Ick, that is a mouthful. Is it really worth the double cast so you can call the
other form of toDataCue and not duplicate the ASSERT here?

> Source/WebCore/html/track/TextTrack.cpp:283
>  
> +    if (cue->cueType() == TextTrackCue::Data && kind() != metadataKeyword())
{

Nit: I think it would be helpful to include the spec text here as a comment.