[webkit-reviews] review granted: [Bug 128397] AX: Add text replacement activity support to NSAccessibilitySelectTextWithCriteriaParameterizedAttribute. : [Attachment 223807] Fixed patch.

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Samuel White
<samuel_white at apple.com>'s request for review:
Bug 128397: AX: Add text replacement activity support to
NSAccessibilitySelectTextWithCriteriaParameterizedAttribute.
https://bugs.webkit.org/show_bug.cgi?id=128397

Attachment 223807: Fixed patch.
https://bugs.webkit.org/attachment.cgi?id=223807&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223807&action=review


> Source/WebCore/accessibility/AccessibilityObject.h:406
> +    AccessibilitySelectTextCriteria(AccessibilitySelectTextActivity
activity, AccessibilitySelectTextAmbiguityResolution ambiguityResolution,
String replacementString)

I think this can be const String&, since we're going to copy it anyway with ,
replacementString(replacementString)

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:637
> +	   if ([activityParameter
isEqualToString:NSAccessibilitySelectTextActivityFindAndReplace])

you can probably put this if statement together with the one above