[webkit-reviews] review granted: [Bug 128582] Stop using PLATFORM(MAC) in WebKit2/=?UTF-8?Q?Shared=20except=20where=20it=20means=20=E2=80=9COS=20X=20but=20not=20iOS=E2=80=9D=20?=: [Attachment 223815] Replace PLATFORM(MAC)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 128582: Stop using PLATFORM(MAC) in WebKit2/Shared except where it means
“OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128582

Attachment 223815: Replace PLATFORM(MAC)
https://bugs.webkit.org/attachment.cgi?id=223815&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223815&action=review


> Source/WebKit2/Shared/NativeWebKeyboardEvent.h:47
> +#if PLATFORM(GTK)
>  #include <WebCore/CompositionResults.h>
>  #include <WebCore/GUniquePtrGtk.h>
>  #include <WebCore/GtkInputMethodFilter.h>
>  typedef union _GdkEvent GdkEvent;
> -#elif PLATFORM(EFL)
> +#endif
> +
> +#if PLATFORM(EFL)
>  #include <Evas.h>
>  #endif

I would put EFL before GTK because I like alphabetical order rather than
arbitrary order for such things.