[webkit-reviews] review denied: [Bug 128590] [CSS Regions] Overflow above the first region is not properly painted for regions with padding : [Attachment 223833] Patch

[bugzilla-daemon at webkit.org]

Andrei Bucur <abucur at adobe.com> has denied Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 128590: [CSS Regions] Overflow above the first region is not properly
painted for regions with padding
https://bugs.webkit.org/show_bug.cgi?id=128590

Attachment 223833: Patch
https://bugs.webkit.org/attachment.cgi?id=223833&action=review

------- Additional Comments from Andrei Bucur <abucur at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223833&action=review


> Source/WebCore/ChangeLog:10
> +	   anonymous regions, regions never have borders/padding/margins. All
of these are found 

The CL should emphasize the technical problem is we use the layer of the region
container (with a coordinate system) but we offset the content using the
location of the region. If the anonymous region had a layer and we used that
instead of the region container layer, there wouldn't have been any problems.
It's less important the fact anonymous regions don't have
borders/padding/margins.

> Source/WebCore/rendering/RenderLayer.cpp:5250
> +    LayoutRect regionContentBox =
region->regionContainer()->contentBoxRect();

mapLayerClipRectsToFragmentationLayer can take just
RenderNamedFlowThreadFragments as a parameter or generic RenderRegions?

> Source/WebCore/rendering/RenderRegion.cpp:153
> +RenderBlockFlow* RenderRegion::regionContainer() const

Can we move this on RenderNamedFlowFragment? It makes more sense considering we
assert the parent is a RenderNamedFlowFragmentContainer.