[webkit-reviews] review granted: [Bug 128484] Add the basic infrastructure to compile attributes matching in selectors : [Attachment 223604] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128484: Add the basic infrastructure to compile attributes matching in
selectors
https://bugs.webkit.org/show_bug.cgi?id=128484

Attachment 223604: Patch
https://bugs.webkit.org/attachment.cgi?id=223604&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223604&action=review


> Source/WebCore/cssjit/SelectorCompiler.cpp:414
>	   }

It looks like the code above here could be simpler if you fully handled the
success case above the failure cases? – it would duplicate the restore, but
that's a couple of extra loads & it would save a jump.

> Source/WebCore/cssjit/SelectorCompiler.cpp:992
> +    // In general, canonicalLocalName and localName are the same. When they
differe, we have to check if the node is HTML to know

differe

> Source/WebCore/dom/Attribute.h:86
> +    return Attribute::nameMatchesFilter(m_name, prefix, localName,
namespaceURI);

I don't think you need "Attribute::"?