[webkit-reviews] review granted: [Bug 128565] [WK2] Add support for image document viewport configuration : [Attachment 223768] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128565: [WK2] Add support for image document viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=128565

Attachment 223768: Patch
https://bugs.webkit.org/attachment.cgi?id=223768&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223768&action=review


> Source/WebCore/page/ViewportConfiguration.h:87
> +    static Parameters imageParameters();

I'd call these textDocumentParamters, imageDocumentParameters.

> Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm:269
>  IntPoint PageClientImpl::screenToWindow(const IntPoint& point)
>  {
> -    notImplemented();
> -    return IntPoint();
> +    return IntPoint([m_view convertPoint:point fromView:nil]);
>  }
>  
>  IntRect PageClientImpl::windowToScreen(const IntRect& rect)
>  {
> -    notImplemented();
> -    return IntRect();
> +    return enclosingIntRect([m_view convertRect:rect toView:nil]);
>  }

Are these changes related to the patch?