[webkit-reviews] review granted: [Bug 128558] WK2 AVKit enter fullscreen doesn't work a second time. : [Attachment 223757] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 128558: WK2 AVKit enter fullscreen doesn't work a second time.
https://bugs.webkit.org/show_bug.cgi?id=128558

Attachment 223757: Patch
https://bugs.webkit.org/attachment.cgi?id=223757&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223757&action=review


> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h:57
> +    WebAVPlayerController *getPlayerController();

This should just be "playerController()", or perhaps "ensurePlayerController()"
due to the lazy-creation.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:225
> +    if (m_videoFullscreenModel)
> +	   m_playerController.get().delegate = m_videoFullscreenModel;

shouldn't this be in the "if (!m_playerController)" case?