[webkit-reviews] review granted: [Bug 128556] 32-bit LLInt writeBarrierOnGlobalObject is wrong : [Attachment 223755] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 128556: 32-bit LLInt writeBarrierOnGlobalObject is wrong
https://bugs.webkit.org/show_bug.cgi?id=128556

Attachment 223755: Patch
https://bugs.webkit.org/attachment.cgi?id=223755&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223755&action=review


r=me

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:413
> +	   loadConstantOrVariableCell(t1, t0, .writeBarrierDone)
>	   btpz t0, .writeBarrierDone

Why does this code check for a null t0? Is a null cell ever allowed?