[webkit-reviews] review granted: [Bug 128538] ContentData equals() methods are not inline-able : [Attachment 223726] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 128538: ContentData equals() methods are not inline-able
https://bugs.webkit.org/show_bug.cgi?id=128538

Attachment 223726: Patch v1
https://bugs.webkit.org/attachment.cgi?id=223726&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223726&action=review


> Source/WebCore/rendering/style/ContentData.h:68
> +    ContentData(Type type)

explicit

> Source/WebCore/rendering/style/ContentData.h:160
>      const CounterContent* counter() const { return m_counter.get(); }

Seems like this should return a reference rather than a pointer, unless it can
be null.