[webkit-reviews] review granted: [Bug 128487] IDB: storage/indexeddb/mozilla/object-store-remove-values.html fails : [Attachment 223740] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 128487: IDB: storage/indexeddb/mozilla/object-store-remove-values.html
fails
https://bugs.webkit.org/show_bug.cgi?id=128487

Attachment 223740: Patch v1
https://bugs.webkit.org/attachment.cgi?id=223740&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223740&action=review


> Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:62
> +    if (m_uniqueIDBDatabase)

early return instead?

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:166
> +    while (performNextMainThreadTaskWithoutAdoptRef())
> +    {
> +    }

Indentation/brace location looks weird to me.

>
Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQ
Lite.cpp:79
> +	   JSLockHolder lockHolder(JSLockHolder(m_vm.get()));

wut