[webkit-reviews] review granted: [Bug 128546] [MSE] Fix layering violations in MediaSource : [Attachment 223732] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 10 13:03:59 PST 2014


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 128546: [MSE] Fix layering violations in MediaSource
https://bugs.webkit.org/show_bug.cgi?id=128546

Attachment 223732: Patch
https://bugs.webkit.org/attachment.cgi?id=223732&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223732&action=review


> Source/WebCore/platform/graphics/MediaPlayer.cpp:395
> +bool MediaPlayer::load(const URL& url, const ContentType& contentType,
MediaSourcePrivateClient* mediaSource)
>  {
>      m_mediaSource = mediaSource;

Nit: I think it is worth adding an ASSERT because you now take a raw pointer.


More information about the webkit-reviews mailing list