[webkit-reviews] review granted: [Bug 128540] Obj-C API: JSExport doesn't work for methods that contain protocols in their type signature : [Attachment 223728] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 128540: Obj-C API: JSExport doesn't work for methods that contain protocols
in their type signature
https://bugs.webkit.org/show_bug.cgi?id=128540

Attachment 223728: Patch
https://bugs.webkit.org/attachment.cgi?id=223728&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223728&action=review


> Source/JavaScriptCore/API/ObjcRuntimeExtras.h:198
> +		   position = index(++position, '"') + 1;

This feels at first like something that would give you victory at the IOCCC.  I
eventually figured it.	But maybe you an come up with a better idiom for this
at some point?