[webkit-reviews] review granted: [Bug 127554] [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr : [Attachment 223627] Rebased patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 10 05:55:51 PST 2014


Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 127554: [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=127554

Attachment 223627: Rebased patch
https://bugs.webkit.org/attachment.cgi?id=223627&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223627&action=review


> Source/WebCore/platform/gtk/PasteboardHelper.cpp:-272
> -	       // FIXME: should GOwnPtr be smarter about this and replace the
existing ptr when outPtr() is used?
> -	       key.clear();
> -	       value.clear();

\o/


More information about the webkit-reviews mailing list