[webkit-reviews] review granted: [Bug 128450] Remove unnecessary spinLock in JSLock. : [Attachment 223678] patch 2: removes spinLock.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 128450: Remove unnecessary spinLock in JSLock.
https://bugs.webkit.org/show_bug.cgi?id=128450

Attachment 223678: patch 2: removes spinLock.
https://bugs.webkit.org/attachment.cgi?id=223678&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223678&action=review


This looks right to me.  I recommend getting a second review since this is
tricky code.  Also please remove any unnecessary scopes now that you're not
using them for the destruction of SpinLockHolders.

> Source/JavaScriptCore/runtime/JSLock.cpp:113
>      {

This nesting scope is no longer necessary now that you've removed the
SpinLockHolder.