[webkit-reviews] review granted: [Bug 128513] Stop using PLATFORM(MAC) in WebKit2/=?UTF-8?Q?platform=20except=20where=20it=20means=20=E2=80=9COS=20X=20but=20not=20iOS=E2=80=9D=20?=: [Attachment 223670] Change PLATFORM(MAC), do some moves and renames

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 128513: Stop using PLATFORM(MAC) in WebKit2/platform except where it means
“OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128513

Attachment 223670: Change PLATFORM(MAC), do some moves and renames
https://bugs.webkit.org/attachment.cgi?id=223670&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223670&action=review


> Source/WebKit2/ChangeLog:3
> +	   Stop using PLATFORM(MAC) in WebKit2/platform except where it means
“OS X but not iOS”

I assume your smart quotes were just munged by the review tool.

> Source/WebKit2/Platform/cf/ModuleCF.cpp:27
> +#import "config.h"
> +#import "Module.h"

Did you mean #include?

> Source/WebKit2/Platform/cf/ModuleCF.cpp:27
> -#import "config.h"
> -#import "Module.h"
> +#include "config.h"
> +#include "Module.h"

I'm confused by this patch. It seems ModuleCF.cpp has two separate patch
entries!