[webkit-reviews] review granted: [Bug 128468] Manage MutationObserverInterestGroup through std::unique_ptr : [Attachment 223581] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 8 17:44:30 PST 2014


Andreas Kling <akling at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128468: Manage MutationObserverInterestGroup through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128468

Attachment 223581: Patch
https://bugs.webkit.org/attachment.cgi?id=223581&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223581&action=review


r=me

> Source/WebCore/dom/MutationObserverInterestGroup.h:75
> +    static std::unique_ptr<MutationObserverInterestGroup>
createIfNeeded(Node& target, MutationObserver::MutationType,
MutationRecordDeliveryOptions oldValueFlag, const QualifiedName* attributeName
= 0);

Let's change 0 to nullptr too since we're touching this.


More information about the webkit-reviews mailing list