[webkit-reviews] review granted: [Bug 128423] IDB: storage/indexeddb/mozilla/cursors.html fails : [Attachment 223547] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 8 15:42:35 PST 2014


mitz at webkit.org <mitz at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 128423: IDB: storage/indexeddb/mozilla/cursors.html fails
https://bugs.webkit.org/show_bug.cgi?id=128423

Attachment 223547: Patch v1
https://bugs.webkit.org/attachment.cgi?id=223547&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223547&action=review


> Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:159
>	       m_callbacks->onSuccess(static_cast<SharedBuffer*>(0));

Why do we need this cast? Can’t we just say nullptr? Is there some weird
overloading issue?


More information about the webkit-reviews mailing list