[webkit-reviews] review granted: [Bug 128457] Stop using getCharactersWithUpconvert in JavaScriptCore : [Attachment 223570] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 128457: Stop using getCharactersWithUpconvert in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=128457

Attachment 223570: Patch
https://bugs.webkit.org/attachment.cgi?id=223570&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223570&action=review


Nice! r=me

> Source/WTF/wtf/text/StringView.h:141
> +	   if (is8Bit())
> +	       return WTF::find(characters8(), length(), character, start);

I wonder if it would be useful to have an early return here if 'character' is
outside the LChar range. NABD.