[webkit-reviews] review denied: [Bug 128450] DropAllLocks should let JSLock lock its spinLock : [Attachment 223560] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 8 10:50:35 PST 2014


Geoffrey Garen <ggaren at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 128450: DropAllLocks should let JSLock lock its spinLock
https://bugs.webkit.org/show_bug.cgi?id=128450

Attachment 223560: the patch.
https://bugs.webkit.org/attachment.cgi?id=223560&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This code implies that the spinlock guards m_lockCount, and that multiple
threads might point to the same JSLock. If so, it's not valid to read
m_lockCount without holding the spinlock.


More information about the webkit-reviews mailing list