[webkit-reviews] review granted: [Bug 128333] Web Inspector: show probe sets for script content views in the details sidebar : [Attachment 223545] patch - maybe needs new asset instead of PDF glyph

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 128333: Web Inspector: show probe sets for script content views in the
details sidebar
https://bugs.webkit.org/show_bug.cgi?id=128333

Attachment 223545: patch - maybe needs new asset instead of PDF glyph
https://bugs.webkit.org/attachment.cgi?id=223545&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223545&action=review


> Source/WebInspectorUI/UserInterface/DataGrid.js:385
> +    insertColumn: function(columnIdentifier, columnData, insertionIndex) {

Some newlines in this function would help readability.

> Source/WebInspectorUI/UserInterface/DataGrid.js:399
> +	   console.log("columns ", this.orderedColumns.slice());

Debug statement.

> Source/WebInspectorUI/UserInterface/ProbeSetDataGridNode.js:101
> +	       default: console.log("Don't know how to represent sample:",
sample);

console.error?