[webkit-reviews] review granted: [Bug 128410] Add API for accessing session ephemerality from a page bundle : [Attachment 223523] expose just the bool from bundle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 8 02:26:42 PST 2014


Alexey Proskuryakov <ap at webkit.org> has granted Martin Hock <mhock at apple.com>'s
request for review:
Bug 128410: Add API for accessing session ephemerality from a page bundle
https://bugs.webkit.org/show_bug.cgi?id=128410

Attachment 223523: expose just the bool from bundle
https://bugs.webkit.org/attachment.cgi?id=223523&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223523&action=review


> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2110
> +bool WebPage::isEphemeral() const

Why not use the same name, isUsingEphemeralSession()? "Page is ephemeral" is
not a concept we have.


More information about the webkit-reviews mailing list