[webkit-reviews] review granted: [Bug 128448] [Mac] Fix use of availability macros on recently-added APIs : [Attachment 223558] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 128448: [Mac] Fix use of availability macros on recently-added APIs
https://bugs.webkit.org/show_bug.cgi?id=128448

Attachment 223558: Patch
https://bugs.webkit.org/attachment.cgi?id=223558&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223558&action=review


> Source/JavaScriptCore/ChangeLog:10
> +	   newer OS X versions would expand in to when building on older OS
versions.

Typo: “in to”.

> Source/JavaScriptCore/API/WebKitAvailability.h:63
> +#else /* __APPLE__ */

Comments next to #else are ambiguous and confusing. Either remove the comment
or change to #endif followed by #ifndef (__APPLE__)

> Source/JavaScriptCore/postprocess-headers.sh:12
> +for HEADER in JSBase.h JSContext.h JSManagedValue.h JSValue.h
JSVirtualMachine.h WebKitAvailability.h; do

It would be nicer to instead iterate over ${SCRIPT_INPUT_FILE_${i}} here for $i
from 0 to $SCRIPT_INPUT_FILE_COUNT.