[webkit-reviews] review denied: [Bug 128449] [GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage : [Attachment 223557] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Piotr Grad
<p.grad at samsung.com>'s request for review:
Bug 128449: [GTK] Build break in
WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage
https://bugs.webkit.org/show_bug.cgi?id=128449

Attachment 223557: Patch
https://bugs.webkit.org/attachment.cgi?id=223557&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223557&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:957
> +    webPageConfiguration.relatedPage =
webkitWebViewBaseGetPage(webkitWebViewBase);

This is not correct, you are using the page you are creating as the related
page. You should not initialize the related page (it's already null at this
point), is currently unimplemented in gtk+ port.