[webkit-reviews] review denied: [Bug 128406] Fix bug in stack limit adjustments in JSLock. : [Attachment 223505] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 128406: Fix bug in stack limit adjustments in JSLock.
https://bugs.webkit.org/show_bug.cgi?id=128406

Attachment 223505: the patch.
https://bugs.webkit.org/attachment.cgi?id=223505&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Let's turn this into three patches:

(1) A three-line patch that removes the problematic assignment of nullptr even
if not dropping the lock, and removes the problematic testing of
"m_vm->stackPointerAtVMEntry == entryStackPointer".

(2) A mechanical patch that re-enables stack checking.

(3) The re-architectural you've proposed here, which removes the iOS-specific
code path.

For (3), I think we need a little research into why that path currently exists,
and is iOS-specific. I believe it was needed to fix some nasty bugs -- so we
shouldn't just remove it without knowledge of why it's there.