[webkit-reviews] review granted: [Bug 128404] Stop using PLATFORM(MAC) in WebCore/=?UTF-8?Q?platform=20except=20where=20it=20means=20=E2=80=9COS=20X=20but=20not=20iOS=E2=80=9D=20?=: [Attachment 223503] Replace PLATFORM(MAC) with equivalent alternatives

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 7 15:33:10 PST 2014


Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 128404: Stop using PLATFORM(MAC) in WebCore/platform except where it means
“OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128404

Attachment 223503: Replace PLATFORM(MAC) with equivalent alternatives
https://bugs.webkit.org/attachment.cgi?id=223503&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223503&action=review


> Source/WebCore/platform/graphics/IntRect.h:196
> +#if PLATFORM(MAC) && !PLATFORM(IOS)
&&!defined(NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES)

&&!defined

> Source/WebCore/platform/mac/WebCoreSystemInterface.h:68
> +#if PLATFORM(COCOA) && USE(CA)

Is USE(CA) even needed here.


More information about the webkit-reviews mailing list