[webkit-reviews] review granted: [Bug 128389] [GTK] Make process model names properly meaningful : [Attachment 223492] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 128389: [GTK] Make process model names properly meaningful
https://bugs.webkit.org/show_bug.cgi?id=128389

Attachment 223492: Patch
https://bugs.webkit.org/attachment.cgi?id=223492&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223492&action=review


Looks good to me. Needs one more GTK+ reviewer to be committed.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:935
> +    if (newProcessModel != context->priv->context->processModel()) {
> +	   context->priv->context->setUsesNetworkProcess(newProcessModel ==
ProcessModelMultipleSecondaryProcesses);
> +	   context->priv->context->setProcessModel(newProcessModel);

Nit: This should probably be an early return.