[webkit-reviews] review granted: [Bug 128233] Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters : [Attachment 223458] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 7 08:59:45 PST 2014
Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 128233: Change TextIterator to use StringView, preparing to wean it from
deprecatedCharacters
https://bugs.webkit.org/show_bug.cgi?id=128233
Attachment 223458: Patch
https://bugs.webkit.org/attachment.cgi?id=223458&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223458&action=review
> Source/WebCore/platform/text/mac/TextBoundaries.mm:219
> + RetainPtr<CFStringRef> uniString = text.createCFStringWithoutCopying();
> + RetainPtr<CFStringRef> foundWord = text.substring(*start, *end -
*start).createCFStringWithoutCopying();
These can both be auto.
More information about the webkit-reviews
mailing list