[webkit-reviews] review granted: [Bug 127427] [EFL] Spelling unit tests should use ecore_main_loop_iterate() : [Attachment 222105] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 7 03:51:23 PST 2014
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Lukasz Bialek
<l.bialek at samsung.com>'s request for review:
Bug 127427: [EFL] Spelling unit tests should use ecore_main_loop_iterate()
https://bugs.webkit.org/show_bug.cgi?id=127427
Attachment 222105: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=222105&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222105&action=review
rs=me
>>
Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:243
>> + void* actual = 0;
>
> nullptr instead of 0.
Please fix this one before landing.
>>
Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:249
>> + actual = 0;
>
> nullptr again.
ditto.
More information about the webkit-reviews
mailing list