[webkit-reviews] review granted: [Bug 119808] FloatingObject m_paginationStrut should be LayoutUnit : [Attachment 223293] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 7 01:45:04 PST 2014


Andreas Kling <akling at apple.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 119808: FloatingObject m_paginationStrut should be LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=119808

Attachment 223293: Patch
https://bugs.webkit.org/attachment.cgi?id=223293&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223293&action=review


r=me

> Source/WebCore/ChangeLog:13
> +	   Also, stop copying the originatingLine in
FloatingObject::unsafeClone
> +	   because that allows a FloatingObject to point to a line for a
renderer
> +	   that it doesn't belong to.

I would do this in a separate change.


More information about the webkit-reviews mailing list