[webkit-reviews] review granted: [Bug 128354] [WK2] Fitler touch events only based on touch start : [Attachment 223413] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 23:01:26 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128354: [WK2] Fitler touch events only based on touch start
https://bugs.webkit.org/show_bug.cgi?id=128354

Attachment 223413: Patch
https://bugs.webkit.org/attachment.cgi?id=223413&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223413&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:1380
> +bool WebPageProxy::shouldTrackTouchEvents(const WebTouchEvent& event)

Odd that the name says "events" but the argument is "event".

Maybe this should be shouldStartTrackingTouchEvents?

The function can be |const|


More information about the webkit-reviews mailing list