[webkit-reviews] review granted: [Bug 128351] [iOS] make should build WebKit2 : [Attachment 223412] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 128351: [iOS] make should build WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128351

Attachment 223412: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=223412&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223412&action=review


> Source/Makefile:-7
> -ifneq (,$(findstring iphoneos,$(SDKROOT)))
> -	MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit
> -else ifneq (,$(findstring iphonesimulator,$(SDKROOT)))
> -	MODULES = WTF JavaScriptCore ThirdParty/ANGLE WebCore WebKit
> -endif

Do we build WebInspectorUI for iOS? If not, then we need to exclude it from the
iOS device and simulator builds.