[webkit-reviews] review granted: [Bug 128347] Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg : [Attachment 223409] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 128347: Workaround REGRESSION(r163195-r163227): Crash beneath
NSErrorUserInfoFromJSException when installing AppleInternal.mpkg
https://bugs.webkit.org/show_bug.cgi?id=128347

Attachment 223409: Patch
https://bugs.webkit.org/attachment.cgi?id=223409&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223409&action=review


r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   Added a flag to VM class called m_ignoreStackLimit that disables
stack limit checks.
> +	   We set this flag in JSContextGroupCreate() and
JSGlobalContextCreateInGroup().
> +
> +	   Disabled stack overflow tests in testapi.js since it uses these
paths.

You should explain that this is a temporary work-around, which we will remove
once we have a proper fix. Otherwise, someone who's not you or me will think
that we've removed stack checking from JavaScriptCore, and they will be
reasonably alarmed.