[webkit-reviews] review canceled: [Bug 128322] LayoutTestHelper missing ASAN_OTHER_LDFLAGS in its xcconfig : [Attachment 223407] Patch

[bugzilla-daemon at webkit.org]

David Farler <dfarler at apple.com> has canceled David Farler
<dfarler at apple.com>'s request for review:
Bug 128322: LayoutTestHelper missing ASAN_OTHER_LDFLAGS in its xcconfig
https://bugs.webkit.org/show_bug.cgi?id=128322

Attachment 223407: Patch
https://bugs.webkit.org/attachment.cgi?id=223407&action=review

------- Additional Comments from David Farler <dfarler at apple.com>
 67 TOOLCHAINS = $(TOOLCHAINS_$(PLATFORM_NAME));
 68 TOOLCHAINS_iphoneos = $(TOOLCHAINS);
 69 TOOLCHAINS_iphonesimulator = $(TOOLCHAINS);
 70 TOOLCHAINS_macosx = $(TOOLCHAINS_macosx_$(MAC_OS_X_VERSION_MAJOR));
 71 TOOLCHAINS_macosx_1080 = default;
 72 TOOLCHAINS_macosx_1090 = $(TOOLCHAINS);
 73 TOOLCHAINS_macosx_101000 = $(TOOLCHAINS_macosx_1090);

Well, that’s not really going to work out.