[webkit-reviews] review denied: [Bug 127361] ASSERTION FAILED: std::isfinite(num) in WebCore::CSSPrimitiveValue::CSSPrimitiveValue : [Attachment 223372] Proposed patch

Thu Feb 6 16:16:54 PST 2014

Benjamin Poulain <benjamin at webkit.org> has denied Martin Hodovan
<hodovanmartin at gmail.com>'s request for review:
Bug 127361: ASSERTION FAILED: std::isfinite(num) in 
WebCore::CSSPrimitiveValue::CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=127361

Attachment 223372: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=223372&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223372&action=review

Looks good but. The test fails.

> LayoutTests/fast/css/parsing-infinite-floating-value.html:16
> +	<head>
> +		<script>
> +				if (window.testRunner)
> +				    testRunner.dumpAsText();
> +		</script>
> +	</head>
> +
> +	<body>
> +		<p>This test passes if it does not crash.</p>
> +
> +		<svg xmlns="http://www.w3.org/2000/svg" >
> +			<polyline font-size="8E+617%"></polyline>
> +		</svg>
> +
> +	</body>

Let's fix the indent here.

Can you please extend the test to non SVG values? It would be useful to test
some HTML.