[webkit-reviews] review granted: [Bug 127852] [CSS Shapes] Rounded Insets Let Content Overlap Shape : [Attachment 223354] Patch

[bugzilla-daemon at webkit.org]

Bem Jones-Bey <bjonesbe at adobe.com> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 127852: [CSS Shapes] Rounded Insets Let Content Overlap Shape
https://bugs.webkit.org/show_bug.cgi?id=127852

Attachment 223354: Patch
https://bugs.webkit.org/attachment.cgi?id=223354&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223354&action=review


> Source/WebCore/css/LengthFunctions.h:41
> +FloatSize floatSizeForLengthSize(const LengthSize&, float maxWidth, float
maxHeight);

I think it's ok as is, but I could see an argument for using a const FloatSize&
instead of two floats. I'll leave that call up to you, since I'm not sure if
it's better or not.