[webkit-reviews] review granted: [Bug 128323] [Win] Correct IME Regression after r141479 : [Attachment 223365] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 12:24:54 PST 2014


Tim Horton <thorton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 128323: [Win] Correct IME Regression after r141479
https://bugs.webkit.org/show_bug.cgi?id=128323

Attachment 223365: Patch
https://bugs.webkit.org/attachment.cgi?id=223365&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223365&action=review


> Source/WebKit/win/WebView.cpp:-5556
> -    if (targetFrame)
> -	   targetFrame->editor().cancelComposition();
> -

updateSelectionForIME is not the only caller of resetIME, please revert this
part.


More information about the webkit-reviews mailing list