[webkit-reviews] review granted: [Bug 128293] Transfer the non-fast-scrollable region to the UI process for iOS : [Attachment 223297] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 128293: Transfer the non-fast-scrollable region to the UI process for iOS
https://bugs.webkit.org/show_bug.cgi?id=128293

Attachment 223297: Patch
https://bugs.webkit.org/attachment.cgi?id=223297&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223297&action=review


That is great, thanks a lot for fixing this!

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h:81
> +    virtual void frameViewNonFastScrollableRegionChanged(FrameView*);

Missing override here.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:1387
>      if (m_needTouchEvents && !m_isPageSuspended) {

I think you can nuke m_needTouchEvents.