[webkit-reviews] review granted: [Bug 128277] WK2: Tap highlight is positioned incorrectly in iframes : [Attachment 223277] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 5 17:02:47 PST 2014


Benjamin Poulain <benjamin at webkit.org> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 128277: WK2: Tap highlight is positioned incorrectly in iframes
https://bugs.webkit.org/show_bug.cgi?id=128277

Attachment 223277: Patch
https://bugs.webkit.org/attachment.cgi?id=223277&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223277&action=review


Thanks!

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:328
> +		  
currentQuad.setP1(view->contentsToRootView(IntPoint(currentQuad.p1())));
> +		  
currentQuad.setP2(view->contentsToRootView(IntPoint(currentQuad.p2())));
> +		  
currentQuad.setP3(view->contentsToRootView(IntPoint(currentQuad.p3())));
> +		  
currentQuad.setP4(view->contentsToRootView(IntPoint(currentQuad.p4())));

Can you please file a bug to me to convert this to floating point?


More information about the webkit-reviews mailing list