[webkit-reviews] review granted: [Bug 127050] [XHR] Ensure response return null when error flag is set for blob and arraybuffer : [Attachment 222587] Limiting change to arraybuffer and blob

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 127050: [XHR] Ensure response return null when error flag is set for blob
and arraybuffer
https://bugs.webkit.org/show_bug.cgi?id=127050

Attachment 222587: Limiting change to arraybuffer and blob
https://bugs.webkit.org/attachment.cgi?id=222587&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222587&action=review


> Source/WebCore/bindings/js/JSXMLHttpRequestCustom.cpp:193
> +    // FIXME: Use CachedAttribute for other types than JSON as well.

I'm not sure why this is something we'd want to do.

Other types are pure DOM ones, so caching in XMLHttpRequest is sufficient - and
if the returned object has a wrapper already, we'll pick up that wrapper.

I see that you only moved this comment, yet it would be good to clarify it.