[webkit-reviews] review denied: [Bug 128223] Declare GlyphBuffers on the heap instead of the stack : [Attachment 223183] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 5 11:56:49 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 128223: Declare GlyphBuffers on the heap instead of the stack
https://bugs.webkit.org/show_bug.cgi?id=128223

Attachment 223183: Patch
https://bugs.webkit.org/attachment.cgi?id=223183&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
It's not clear to me that this the correct solution.
Why is GlyphBuffer so big? Can its inline capacities be reduced?
Does this patch slow us down? Should we cache a GlyphBuffer?


More information about the webkit-reviews mailing list