[webkit-reviews] review granted: [Bug 127559] Run UserAgentScripts through jsmin rather than the css preprocessor : [Attachment 222733] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 127559: Run UserAgentScripts through jsmin rather than the css preprocessor
https://bugs.webkit.org/show_bug.cgi?id=127559

Attachment 222733: Patch
https://bugs.webkit.org/attachment.cgi?id=222733&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222733&action=review


> Source/WebCore/Scripts/make-js-file-arrays.py:60
> +    print >> sourceFile, '#include "%s"' % os.path.basename(headerPath)

Fairly sure % is deprecated and you should be using .format and the new syntax.


> Source/WebCore/Scripts/make-js-file-arrays.py:73
> +	       characters = inputStream.read(-1)

-1 is the default here, and weird to use explicitly