[webkit-reviews] review granted: [Bug 127117] Web Inspector: add probe manager and model objects to the frontend : [Attachment 223166] patch2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 127117: Web Inspector: add probe manager and model objects to the frontend
https://bugs.webkit.org/show_bug.cgi?id=127117

Attachment 223166: patch2
https://bugs.webkit.org/attachment.cgi?id=223166&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223166&action=review


> Source/WebInspectorUI/UserInterface/DebuggerManager.js:514
> -	   console.assert(!breakpoint.id);
> +	   console.assert(!breakpoint.identifier);

Can you revert this?

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:517
> -	   if (breakpoint.id || breakpoint.disabled)
> +	   if (breakpoint.identifier || breakpoint.disabled)

Ditto.

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:527
> -	       breakpoint.id = breakpointIdentifier;
> +	       breakpoint.identifier = breakpointIdentifier;

Ditto.

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:571
> -	   if (!breakpoint.id)
> +	   if (!breakpoint.identifier)

Ditto.

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:579
> -	       delete this._breakpointIdMap[breakpoint.id];
> +	       delete this._breakpointIdMap[breakpoint.identifier];

Ditto.

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:581
> -	       breakpoint.id = null;
> +	       breakpoint.identifier = null;

Ditto.

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:590
> -	   DebuggerAgent.removeBreakpoint(breakpoint.id,
didRemoveBreakpoint.bind(this));
> +	   DebuggerAgent.removeBreakpoint(breakpoint.identifier,
didRemoveBreakpoint.bind(this));

Ditto.

> Source/WebInspectorUI/UserInterface/DebuggerManager.js:599
> -	   if (!breakpoint.id || breakpoint.disabled)
> +	   if (!breakpoint.identifier || breakpoint.disabled)

Ditto.