[webkit-reviews] review granted: [Bug 128190] [CSS Shapes] Add initial performance test for shape-outside: content-box : [Attachment 223127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 4 13:06:56 PST 2014


Ryosuke Niwa <rniwa at webkit.org> has granted Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 128190: [CSS Shapes] Add initial performance test for shape-outside:
content-box
https://bugs.webkit.org/show_bug.cgi?id=128190

Attachment 223127: Patch
https://bugs.webkit.org/attachment.cgi?id=223127&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223127&action=review


> PerformanceTests/ChangeLog:15
> +	   * Layout/Shapes/ShapeOutsideContentBox.html: Added.

Please skip the test by default in Skipped for now since this looks like a
micro benchmark.

> PerformanceTests/Layout/Shapes/ShapeOutsideContentBox.html:6
> +	   <script src="resources/shapes.js"></script>

We should include the script in this file instead for now and extract the
shared code into js as needed.


More information about the webkit-reviews mailing list