[webkit-reviews] review granted: [Bug 128197] WK: Cannot select text inside clickable containers. : [Attachment 223145] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 128197: WK: Cannot select text inside clickable containers.
https://bugs.webkit.org/show_bug.cgi?id=128197

Attachment 223145: Patch
https://bugs.webkit.org/attachment.cgi?id=223145&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223145&action=review


> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:846
> +		   info.url =
linkElement->document().completeURL(stripLeadingAndTrailingHTMLSpaces(linkEleme
nt->getAttribute(HTMLNames::hrefAttr)));
> +	   } else if (element->isLink()) {
>	       info.url =
element->document().completeURL(stripLeadingAndTrailingHTMLSpaces(element->getA
ttribute(HTMLNames::hrefAttr)));
> +	       elementIsLinkOrImage = true;

Would be slightly nice to factor this so you only call completeURL() once.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:852
> +    }
> +    if (!elementIsLinkOrImage) {

I would prefer a blank line between these two.