[webkit-reviews] review granted: [Bug 126210] [GTK][CMake] Generate GObject DOM bindings .symbols files : [Attachment 223109] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 126210: [GTK][CMake] Generate GObject DOM bindings .symbols files
https://bugs.webkit.org/show_bug.cgi?id=126210

Attachment 223109: Patch
https://bugs.webkit.org/attachment.cgi?id=223109&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223109&action=review


Okay! Please look into the dependencies for generate-gdom-symbols-file before
landing though.

> Source/WebCore/PlatformGTK.cmake:735
> +    add_custom_target(generate-gdom-symbols-file
> +	   DEPENDS GObjectDOMBindings
> +    )

It seems like this needs to also depend on all the individual *.symbol files.
in the output.