[webkit-reviews] review granted: [Bug 123832] Use srcset's pixel density to determine intrinsic size : [Attachment 223120] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 4 09:30:30 PST 2014
Dean Jackson <dino at apple.com> has granted Yoav Weiss <yoav at yoav.ws>'s request
for review:
Bug 123832: Use srcset's pixel density to determine intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=123832
Attachment 223120: Patch
https://bugs.webkit.org/attachment.cgi?id=223120&action=review
------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223120&action=review
Go for it, once you've fixed the failure. Thanks Yoav!
> LayoutTests/TestExpectations:64
> +webkit.org/b/124342 fast/hidpi/image-srcset-svg-canvas.html [ Skip ]
> +webkit.org/b/124342 fast/hidpi/image-srcset-svg-canvas-2x.html [ Skip ]
> +webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas-2x.html [
Skip ]
> +webkit.org/b/124349 fast/hidpi/image-srcset-relative-svg-canvas.html [ Skip
]
Maybe we should mark these as failing rather than skipping. That way we won't
forget them when we fix the other bugs.
More information about the webkit-reviews
mailing list