[webkit-reviews] review granted: [Bug 123329] [CSS Regions] Fix Assert SHOULD NEVER BE REACHED in RenderLayer::enclosingElement() : [Attachment 222673] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 4 00:52:35 PST 2014


Mihnea Ovidenie <mihnea at adobe.com> has granted Mihai Maerean
<mmaerean at adobe.com>'s request for review:
Bug 123329: [CSS Regions] Fix Assert SHOULD NEVER BE REACHED in
RenderLayer::enclosingElement()
https://bugs.webkit.org/show_bug.cgi?id=123329

Attachment 222673: patch
https://bugs.webkit.org/attachment.cgi?id=222673&action=review

------- Additional Comments from Mihnea Ovidenie <mihnea at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=222673&action=review


r=me with small tweaks for the tests.

> LayoutTests/fast/regions/assert-hit-test-image.html:19
> +    <p class="result">

Please write the result in a different place. Right now, the description is
overwritten by PASS/FAIL.

>
LayoutTests/fast/regions/auto-size/region-same-height-as-div-with-inline-child.
html:26
> +    <div class="result">

Same as above, lets have the description of the test separate than the result
of running the test.


More information about the webkit-reviews mailing list