[webkit-reviews] review granted: [Bug 127687] ASSERTION FAILED: !object || (object->isRenderBlock()) : [Attachment 222667] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 3 20:49:47 PST 2014


Ryosuke Niwa <rniwa at webkit.org> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 127687: ASSERTION FAILED: !object || (object->isRenderBlock())
https://bugs.webkit.org/show_bug.cgi?id=127687

Attachment 222667: Patch 2
https://bugs.webkit.org/attachment.cgi?id=222667&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222667&action=review


>
LayoutTests/fast/regions/selection/position-for-point-inline-content-node.html:
20
> +    <script>
> +	   onMouseUpLogSelectionAndFocus("selected-content", "focus-node",
"focus-offset");
> +    </script>
> +    <script>

Why do we need two script elements?

> LayoutTests/fast/regions/selection/selection-ended-in-empty-region.html:20
> +    <script>
> +	   onMouseUpLogSelectionAndFocus("selected-content", "focus-node",
"focus-offset");
> +    </script>
> +    <script>

Ditto.


More information about the webkit-reviews mailing list