[webkit-reviews] review granted: [Bug 128118] Manage CalcExpressionNode and derived classes through std::unique_ptr instead of OwnPtr : [Attachment 223012] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 3 15:57:05 PST 2014
Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128118: Manage CalcExpressionNode and derived classes through
std::unique_ptr instead of OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=128118
Attachment 223012: Patch
https://bugs.webkit.org/attachment.cgi?id=223012&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223012&action=review
> Source/WebCore/css/CSSCalculationValue.cpp:401
> + std::unique_ptr<CalcExpressionNode>
left(m_leftSide->toCalcValue(style, rootStyle, zoom));
Maybe auto here?
> Source/WebCore/css/CSSCalculationValue.cpp:404
> + std::unique_ptr<CalcExpressionNode>
right(m_rightSide->toCalcValue(style, rootStyle, zoom));
Maybe auto here?
More information about the webkit-reviews
mailing list